feat: add clock_ticker for apps that only need the tick count - #646
ArthurGibert wants to merge 3 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
The ticks are now part of the clock events that's why it was removed earlier. See here:
faderpunk/faderpunk/src/app.rs
Line 317 in 25546b5
Clock::get_ticker is gone and ClockEvent::Tick carries the tick number. The app polls the counter from several places outside the clock arm, so it uses App::clock_ticker (ATOVproject#646) and takes the tick from the payload where it is already in scope. Authored by an AI coding agent on behalf of kosmar. Co-authored-by: Cursor <cursoragent@cursor.com>
|
I guess as a work-around one could still subscribe to clock events and use a global variable to share the count to the other loops. Now we just need to decide if that's how we want this case to be handled @chmanie . For context PR #644 was meant to bring back the ticker for apps that do not use the clock events: |
|
Following up after reviewing #636/#638: this PR's Beyond that, holding off on this makes sense independent of the rebase issue: there's currently no app in If/when a real app needs this for real, worth reconsidering |
|
you can use a loop like this until we revisit this: |
|
Thanks — we'll use the drain-loop workaround on the WIP apps (dedicated Written by an AI coding agent on @kosmar's behalf. |
Reopens #644, which was merged by mistake on 2026-08-14 and then reverted from
main(force-push reset to the pre-merge commit). Same content, unchanged: three stacked commits (fix/clock-gatekeeper,feat/clock-ticker,feat/app-clock-ticker), sinceTICK_COUNTERis introduced further down the stack.See #644 for the original description and review discussion.